Fix a few mistakes in the README file #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some vim plugins like Gutentags (https://github.com/ludovicchabant/vim-gutentags) write `tags` files into the project directory to keep track of symbols. This file needs to be ignored by git because it should never be committed.
The docs showed that `ToucanClient` is a named export which it isn't. It's a default export, thus the correct way to import the libary is like so: ``` import ToucanClient from 'toucan-sdk' ```
Since different users were introduced in commit #51901639 the comment below the code example was out of date. This also meant that the signer address is not the beneficiary address as it's now two different entities.
pheuberger
changed the title
0xmichalis
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs showed that
ToucanClientis a named export which it isn't.It's a default export, thus the correct way to import the libary is like so:
Please review the
.gitignorechange #102 before this one.I added another commit because it was also pertaining to the docs but the branch name is a bit out of date now.