Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2: LILA-5572/update-redeemauto-function-to-work-like-autoredeem2-in-sdk #89

Conversation

GigaHierz
Copy link
Contributor

  • mark autoRedeem2 as deprecated

@toucan-robot toucan-robot changed the title LILA-5572/update-redeemauto-function-to-work-like-autoredeem2-in-sdk P2: LILA-5572/update-redeemauto-function-to-work-like-autoredeem2-in-sdk Oct 2, 2023
@GigaHierz GigaHierz requested a review from Niwilai October 2, 2023 14:33
Copy link

@Niwilai Niwilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looking good. Some minor comments:

src/subclasses/ContractInteractions.ts Outdated Show resolved Hide resolved
src/typechain/IToucanPoolToken.d.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
…nd map to reduce in the autoredeem functions
@GigaHierz GigaHierz force-pushed the LILA-5572/update-redeemauto-function-to-work-like-autoredeem2-in-sdk branch from 36a184d to e74080d Compare October 5, 2023 21:55
Copy link

@Niwilai Niwilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GigaHierz GigaHierz merged commit d354467 into ToucanProtocol:main Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants