Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): dropdown group borders are not visible #589

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

muratcorlu
Copy link
Contributor

@muratcorlu muratcorlu commented May 24, 2023

This PR does small refactor on Dropdown component.

  • Default text for dropdown button is removed.
  • aria-label for bl-button inside removed, since it's not needed when we have a text inside the button.

@muratcorlu muratcorlu changed the title refactor(dropdown): unneeded default values are removed fix(dropdown): dropdown group borders are not visible May 26, 2023
@muratcorlu muratcorlu marked this pull request as draft May 26, 2023 14:27
@leventozen leventozen marked this pull request as ready for review January 11, 2024 12:41
@leventozen leventozen merged commit 63915ca into next Jan 11, 2024
7 checks passed
@leventozen leventozen deleted the dropdown-refactor branch January 11, 2024 13:08
Copy link

🎉 This PR is included in version 2.4.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jan 25, 2024
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants