-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: Update interface{}
casting to avoid runtime panic
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ok := possibleMap[key].(type)` to avoid run time panics
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 403 401 -2
=========================================
- Hits 403 401 -2 ☔ View full report in Codecov by Sentry. |
GokselKUCUKSAHIN
changed the title
Improvement/ Update inteface{} casting to avoid run time
Improvement/ Update inteface{} casting to avoid runtime Sep 4, 2024
panic
panic
GokselKUCUKSAHIN
changed the title
Improvement/ Update inteface{} casting to avoid runtime
Improvement/ Update Sep 4, 2024
panic
inteface{}
casting to avoid runtime panic
GokselKUCUKSAHIN
changed the title
Improvement/ Update
Improvement/ Update Sep 4, 2024
inteface{}
casting to avoid runtime panic
interface{}
casting to avoid runtime panic
GokselKUCUKSAHIN
changed the title
Improvement/ Update
improvement: Update Sep 4, 2024
interface{}
casting to avoid runtime panic
interface{}
casting to avoid runtime panic
it also improved performance with this update
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances type safety when accessing the
map
fields.Before:
In this example, if
match_all
exists but isn’t castable toObject
, a runtime panic occurs.After:
This change ensures that the key exists and is safely cast to
Object
before modifying it, preventing potential panics.