feat: add connectionBufferSizeMB field in order to specify support mb values #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config 1mb,10mb, 1,5mb etc.
oguzyildirim
approved these changes
Nov 9, 2023
|
No required to keep open this PR, I have opened more expanded version of it: #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the connectionBufferSize config on primary and metadata buckets, we got raw bytes value as
connectionBufferSize: 20971520it's really hard to read and understand the exact value.To get mb related value from users like
5mb, 15mb, 1.5mb, 2.5mbetc. I have added a new field calledconnectionBufferSizeMB. Via this field, users can easily determineetc.
Currently, I try to support connectionBufferSize in not order to break compatibility. I signed this field as deprecated on README.