fix: Multiple nicknames error fixed. #24
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
I would like to express my gratitude for this remarkable project. It significantly facilitates our ability to manage tasks effortlessly, and I truly appreciate it.
Upon attempting to join multiple rooms, I noticed an issue where assigning a different nickname in one grooming room resulted in the alteration of nicknames across all browser instances. Consequently, this pull request aims to address this particular concern.
In certain instances, I deviated from the DRY (Don't Repeat Yourself) principle, notably in the use of the NicknameData types. I refrained from creating a separate file for these types, as it seemed unnecessary for a single type. However, if it is suggested, I am willing to create a dedicated file for types.
Presently, when a user performs create, join, and update nickname operations, the nickname data is stored with the current roomID. This modification enables users to employ distinct nicknames for various grooming rooms.
I would also like to extend my apologies for any inconveniences caused by changes due to Prettier formatting. If you decide to include a configuration file, we can proceed collaboratively in sync.
Additionally, I would like to note that the change in the nickname data type in local storage might impact some users. They may need to clear their storage to ensure proper functionality.
Thank you for your consideration.
Best regards,
Mehmet