Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose android-publisher project in the Gradle plugin #1038

Conversation

JavierSegoviaCordoba
Copy link

Based on the issue #885, applying the Gradle plugin is not enough to be able to fully configure it (at least in conventional plugins).

The reason is there are some necessary APIs in android-publisher that are not exposed directly by the Gradle plugin, forcing the consumer to not only apply the Gradle plugin, also the consumer needs to add the android-publisher artifact.

With this change that requirement is no longer necessary.

@SUPERCILEX
Copy link
Collaborator

That's intentional: the APIs (even those not marked internal) are not designed for public consumption because it would be impossible to please everyone, they just happen to be what GPP needs. You are free to use that artifact, but I make no backwards compatibility guarantees (hence why it's not included by default).

Instead, I recommend using the android publisher API directly if you have advanced logic: https://github.com/googleapis/google-api-java-client-services/tree/main/clients/google-api-services-androidpublisher/v3. And of course, you can copy this repo's code as a starting point.

@SUPERCILEX SUPERCILEX closed this Feb 16, 2022
@JavierSegoviaCordoba
Copy link
Author

@SUPERCILEX why ReleaseStatus is not designed for public consumption?

@SUPERCILEX
Copy link
Collaborator

Oh, didn't realize that's what this PR was getting at. I created #1039 with some ideas to fix it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants