Workaround for colon track names #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle has an [issue](gradle/gradle#862) that `DirectoryProperties.file()` does always resolve file names with colon (`:`) as URI. This breaks when a colon is used as part of a file name. In this case this is needed for the dedicated PlayStore tracks: tv and wear. They require a corresponding prefix separated by a colon, e.g. "tv:internal". See: developers.google.com/android-publisher/tracks#ff-track-name Resolving the file paths without `DirectoryProperty.file` does work around this Gradle issue on Plugin side.
sebokopter
changed the title
|
If you can confirm that everything works in snapshot builds, that'd be great thanks. |
|
@SUPERCILEX Thanks for merging the MR. There's no snapshot build tough, seemingly because the version.txt is missing the snapshot suffix. I've checked the CI: https://github.com/Triple-T/gradle-play-publisher/actions/runs/8207149974/job/22448033711 and the snapshot repo: https://oss.sonatype.org/content/repositories/snapshots/com/github/triplet/gradle/play-publisher/. The latest snapshot is from December 2023. For what it's worth: I've checked my branch locally via |
|
Ah, my bad I'll just make a release then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle has an issue that
DirectoryProperties.file()does always resolve file names with colon (:) as URI. This breaks when a colon is used as part of a file name.In this case this is needed for the dedicated PlayStore tracks: tv and wear. They require a corresponding prefix separated by a colon, e.g. "tv:internal". See: developers.google.com/android-publisher/tracks#ff-track-name
Resolving the file paths without
DirectoryProperty.filedoes work around this Gradle issue on Plugin side.Hey there! So you want to contribute to Gradle Play Publisher?
Before you file this pull request, follow these steps:
If not, go file an issue about this to make sure it is a desirable change.
Closes #1121