Handle release track names containing a colon #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fully without crashing. #1088 For releases named `formfactor:track`, try `formfactor-track.txt` and `track.txt` instead of invalid filename `formfactor:track.txt`
…fully without crashing. #1088 For releases named `formfactor:track`, try `formfactor-track.txt` and `track.txt` instead of invalid filename `formfactor:track.txt`
…le-play-publisher into colon-filename-fix
SUPERCILEX
reviewed
Jun 27, 2024
| val dir = parameters.consoleNamesDir.get() | ||
| val file = dir.file("${track.replace(':', '-')}.txt").asFile.orNull() | ||
| ?: dir.file("${track.substringAfter(':')}.txt").asFile.orNull() | ||
| ?: dir.file("$track.txt").asFile.orNull() |
There was a problem hiding this comment.
Shouldn't this be removed entirely? If you don't have a file named formfactor-track.txt or track.txt, it's still going to crash with this right as it'll try formfactor:track.txt. Pretty sure track.substringAfter(':') covers track as if there's no colon it'll do nothing.
There was a problem hiding this comment.
Good catch, I’m not sure whether simply calling .file("file:with:colon.txt") will crash or return a null instead, but like you said, since .substringAfter(':') covers this, we can just remove this line.
… in other cases, and likely to crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle release track names containing a colon (e.g. wear:alpha) gracefully without crashing.
#1088
For releases named
formfactor:track, tryformfactor-track.txtandtrack.txtinstead of invalid filenameformfactor:track.txthttps://github.com/chimbori/gradle-play-publisher/commit/cb5729afa399e1980231af67cf6670647d479915