Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tonic to 0.11 #49

Closed
wants to merge 3 commits into from
Closed

bump tonic to 0.11 #49

wants to merge 3 commits into from

Conversation

iamazy
Copy link

@iamazy iamazy commented Feb 12, 2024

upgrade tonic to 0.11

@iamazy iamazy requested a review from a team as a code owner February 12, 2024 23:35
@njhill
Copy link

njhill commented Feb 22, 2024

@eopb it would be great if a new version could be released with tonic 0.11! 🙏

@@ -15,7 +15,7 @@ async-trait = "0.1"
http = "0.2"
thiserror = "1"
tokio = { version = "1", features = ["full"] }
tonic = { version = "0.10", features = ["tls"] }
tonic = { version = "0.11", features = ["tls"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a range dependency here to avoid having to make this a breaking change?

Suggested change
tonic = { version = "0.11", features = ["tls"] }
tonic = { version = ">=0.10,<0.12", features = ["tls"] }

@iamazy iamazy requested review from eopb February 24, 2024 01:26
@eopb
Copy link
Member

eopb commented Feb 27, 2024

Thank you for your contribution @iamazy

I'm going to close this in favor of #50 since that PR does not change the formatting of the Cargo.toml files

@eopb eopb closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants