Skip to content

fix: Selection handling when clicking editor padding #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix: Selection handling when clicking editor padding #1629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions examples/06-custom-schema/04-pdf-file-block/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
[data-content-type="pdf"] .bn-file-block-content-wrapper,
[data-content-type="pdf"] .bn-file-and-caption-wrapper {
height: 800px;
width: 100%;
}

[data-content-type="pdf"] embed {
height: 100%;
height: 800px;
width: 100%;
}
5 changes: 4 additions & 1 deletion packages/core/src/blocks/FileBlockContent/helpers/render/createResizableFileBlockWrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ export const createResizableFileBlockWrapper = (

// Ensures the element is not wider than the editor and not narrower than a
// predetermined minimum width.
width = Math.max(newWidth, minWidth);
width = Math.min(
Math.max(newWidth, minWidth),
editor.domElement?.firstElementChild?.clientWidth || Number.MAX_VALUE
);
wrapper.style.width = `${width}px`;
};
// Stops mouse movements from resizing the element and updates the block's
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/editor/Block.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ BASIC STYLES
}

.bn-block-content {
display: flex;
padding: 3px 0;
transition: font-size 0.2s;
width: 100%;
Expand Down Expand Up @@ -163,6 +162,7 @@ NESTED BLOCKS
.bn-block-content::before {
margin-right: 0;
content: "";
display: inline;
}

/* Ordered */
Expand Down
12 changes: 7 additions & 5 deletions packages/react/src/blocks/FileBlockContent/helpers/render/ResizableFileBlockWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,13 @@ export const ResizableFileBlockWrapper = (

// Ensures the child is not wider than the editor and not narrower than a
// predetermined minimum width.
if (newWidth < minWidth) {
setWidth(minWidth);
} else {
setWidth(newWidth);
}
setWidth(
Math.min(
Math.max(newWidth, minWidth),
props.editor.domElement?.firstElementChild?.clientWidth ||
Number.MAX_VALUE
)
);
};
// Stops mouse movements from resizing the child and updates the block's
// `width` prop to the new value.
Expand Down
Loading