feat: Inline style props in external HTML #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/react
@blocknote/mantine
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-docx-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
YousefED
reviewed
Apr 24, 2025
packages/core/src/api/exporters/html/util/serializeBlocksExternalHTML.ts
Outdated
Show resolved
Hide resolved
| <div data-editable="" style="white-space: normal;">React Context Paragraph</div> |
There was a problem hiding this comment.
why is the white-space added?
There was a problem hiding this comment.
This is something that's added automatically to the React node view wrapper. Do we need to get rid of it?
There was a problem hiding this comment.
not sure; just wondering why it wasn't there before? (i.e.: what changed in this PR)?
There was a problem hiding this comment.
Ah, yeah - since we render some props out to inline styles for external HTML, I changed it so inline styles are also preserved (previously only attributes were). The React node view wrapper adds that white space style automatically, so it also gets preserved.
tests/src/unit/core/formatConversion/export/__snapshots__/html/complex/misc.html
Outdated
Show resolved
Hide resolved
matthewlipski
added a commit
that referenced
this pull request
Apr 28, 2025
* Added lossy HTML export/parse equality tests * Fixed list item props in external HTML * Fixed tables in `partialBlockToBlockForTesting` * Added advanced table test * Added comment * feat: Inline style props in external HTML (#1636) * Made default props on default blocks get rendered to inline styles for lossy HTML * Updated unit test snapshots * Implemented PR feedback * Small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes props for default props on default blocks get rendered out to inline styles instead of
data-*attributes when converting to lossy HTML. This is done in a somewhat hacky way as it only happens for default blocks, though after discussing with @YousefED we decided this was ok for now, and will be fixed when changing our default blocks to use the custom blocks API.No tests have been added in this PR, as the ones we need are already in #1605 and #1635, which this PR branches off of.