fix: re-evaluate side-menu on scroll #1830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
| @@ -192,6 +192,12 @@ export class SideMenuView< | |||
| true, | |||
| ); | |||
|
|
|||
| // Update state when the editor scrolls | |||
| this.pmView.root.addEventListener( | |||
There was a problem hiding this comment.
Makes sense, though we already attach an existing onScroll handler a few lines below - wouldn't it make more sense to call this.updateStateFromMousePos there instead of creating an additional listener?
There was a problem hiding this comment.
I didn't see that one! Very true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to resolve a bug where scrolling with a mouse over an element will keep the block side menu attached to the previous block rather than re-evaluating to the new hovered block.
This makes it more inline with normal hover behavior
Left old behavior, Right new behavior:
Screen.Recording.2025-07-09.at.09.52.52.mp4