Disregard compilerOptions.noEmit #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmoore
force-pushed
the
disregard-noemit
branch
from
d968819
to
3e29639
Compare
danielmoore
force-pushed
the
disregard-noemit
branch
from
3e29639
to
bd4a2aa
Compare
|
Is this related to #141? |
|
I don't think so - that issue doesn't seem to have anything to do with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
compilerOptions.noEmitto the blacklist oftsconfig.jsonoptions, as it creates an empty bundle. I think it's reasonable to assume that if someone is usingtsify, they clearly intend to emit something. In my case, I addnoEmitto mytsconfig.jsonto dry-run compile the application directly withtsc.