fix: improve duplicate function detection to handle functions without function keyword #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function keyword, fixed editorconfig issue The previous implementation assumed that function names would always be in the second field when using awk to extract them. This caused issues when the function keyword was omitted, as the function name could be in any field. This fix: 1. Scans all fields in each line for a pattern matching a test function name 2. Uses a proper regex pattern to identify function names 3. Only processes and prints actual function names 4. Adds an explicit return 0 for clarity Added test case to verify the fix works with function declarations that omit the function keyword.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation assumed that function names would always be in the second field when using awk to extract them. This caused issues when the function keyword was omitted, as the function name could be in any field.
This fix:
Added test case to verify the fix works with function declarations that omit the function keyword.