Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps #147

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Deps #147

merged 7 commits into from
Nov 19, 2024

Conversation

dotnetCarpenter
Copy link
Contributor

@dotnetCarpenter dotnetCarpenter commented Nov 10, 2024

This PR builds upon #145. But adds a few things more:

  • Remove yarn and use npm instead.
  • Updates all dependencies.
  • Switch from deprecated tslint to eslint - thereby there is no need for tslint.json (replaced by eslint.config.mjs).
  • By switching to eslint, glob is only included once as version 8 (de-duped).
    • tslint-consistent-codestyle required glob@7 and tslint-consistent-codestyle seems abandon
  • xvfb.init is removed and has been irrelevant since at least remove GabrielBB/xvfb-action #146.

EDIT: I'm marking this ready for review @Tyriar because it's ready.

@dotnetCarpenter
Copy link
Contributor Author

@786maan yarn.lock is deleted and replaced by package-lock.json because @Tyriar said, in #145 (comment), that he wants to remove yarn to simplify things even more.

Another clean up I'd like to do FYI is to remove yarn to simplify things even more.

@dotnetCarpenter dotnetCarpenter marked this pull request as ready for review November 19, 2024 13:16
@dotnetCarpenter
Copy link
Contributor Author

@Tyriar I force pushed to sign all my commits with my signature (I was on a different PC, when I made the PR).

This also deduplicates glob because tslint-consistent-codestyle
was using version 7 of glob and mocha is using version 8.
@dotnetCarpenter
Copy link
Contributor Author

Last commit 2b2238f, means:

$ npm ls cross-spawn
[email protected]
├─┬ [email protected]
│ └── [email protected]
└─┬ [email protected]
  └── [email protected] deduped

Copy link
Owner

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👏

@Tyriar Tyriar merged commit eaf02bb into Tyriar:master Nov 19, 2024
3 checks passed
@dotnetCarpenter dotnetCarpenter deleted the deps branch November 20, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants