Add support for resource policies #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- CliWrap/Utils/ProcessEx.cs: Evaluated as low risk
- CliWrap/ICommandConfiguration.cs: Evaluated as low risk
- CliWrap/Command.cs: Evaluated as low risk
- Readme.md: Evaluated as low risk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
+ Coverage 95.05% 95.37% +0.31%
==========================================
Files 46 48 +2
Lines 1113 1188 +75
Branches 85 86 +1
==========================================
+ Hits 1058 1133 +75
Misses 35 35
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (5)
- CliWrap.Tests/CredentialsSpecs.cs: Evaluated as low risk
- CliWrap/Command.Execution.cs: Evaluated as low risk
- CliWrap/ResourcePolicy.cs: Evaluated as low risk
- CliWrap/Utils/ProcessEx.cs: Evaluated as low risk
- CliWrap/ICommandConfiguration.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
CliWrap.Tests/ResourcePolicySpecs.cs:19
- [nitpick] The error message should be clearer. Suggestion: 'Setting process priority requires elevated permissions on non-Windows platforms, which cannot be guaranteed in a CI environment. Therefore, this test is only run on Windows.'
Starting a process with a custom priority is only supported on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration method called
WithResourcePolicy(...), along with a builder that helps the user configure process's priority, core affinity, and working set.Closes #266