Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rachel/profile drop #159

Merged
merged 9 commits into from
Jul 27, 2021
Merged

Rachel/profile drop #159

merged 9 commits into from
Jul 27, 2021

Conversation

rachel-ellis
Copy link
Collaborator

Overview

Drop down menu with a logout button

Changes

  • components/auth/AuthButton.tsx
  • components/auth/UserProfile.tsx
  • components/Header.tsx

Questions & Notes

Issue tracking

Addressing part of #112

Testing & Demo

@cyrusdiego cyrusdiego linked an issue Jul 15, 2021 that may be closed by this pull request
Implement Profile Drop Down #112
Closed
cyrusdiego
cyrusdiego previously requested changes Jul 16, 2021
View reviewed changes
Copy link
Member

@cyrusdiego cyrusdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with this! Just left a comment and I'm also seeing an error in the dev tools
image

www/src/components/auth/UserProfile.tsx Outdated Show resolved Hide resolved
@rachel-ellis rachel-ellis marked this pull request as draft July 16, 2021 04:40
@armiantos
Copy link
Collaborator

@cyrusdiego are you still seeing the error?

@cyrusdiego
Copy link
Member

@armiantos lol getting a new error now
image

@armiantos
Copy link
Collaborator

Yea sadly this is a material UI limitation as far as I know 🥲

@rachel-ellis rachel-ellis marked this pull request as ready for review July 27, 2021 01:32
@netlify
Copy link

netlify bot commented Jul 27, 2021 •
edited
Loading

✔️ Deploy Preview for amazing-snyder-c0ce1a ready!

🔨 Explore the source changes: 43cdd28

🔍 Inspect the deploy log: https://app.netlify.com/sites/amazing-snyder-c0ce1a/deploys/60ff62def9f6070007399933

😎 Browse the preview: https://deploy-preview-159--amazing-snyder-c0ce1a.netlify.app/

armiantos
armiantos approved these changes Jul 27, 2021
View reviewed changes
Copy link
Collaborator

@armiantos armiantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We might want to do a clean up PR some time in the future

@rachel-ellis rachel-ellis reopened this Jul 27, 2021
@armiantos armiantos requested a review from cyrusdiego July 27, 2021 02:13
@armiantos armiantos dismissed cyrusdiego’s stale review July 27, 2021 02:14

I'm following up this PR with the clean up

@rachel-ellis rachel-ellis merged commit 14c7643 into master Jul 27, 2021
@rachel-ellis rachel-ellis deleted the rachel/profile-drop branch July 27, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armiantos armiantos armiantos approved these changes

@cyrusdiego cyrusdiego Awaiting requested review from cyrusdiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Profile Drop Down
3 participants
@rachel-ellis @armiantos @cyrusdiego