Skip to content

Commit

Permalink
Ms4 final: minor fix on running tests (#76)
Browse files Browse the repository at this point in the history
* Update README.md

* Update and rename README to README.md

* Update README.md

* Update README.md

* Update CHANGELOG.md

* Update README.md

change testing from root to tests/

* Update tests/README.md

* Update tests/README.md

* Update tests/README.md

* Update README.md

---------

Co-authored-by: Farhan Bin Faisal <[email protected]>
  • Loading branch information
adrianl726 and Farhan-Faisal authored Dec 16, 2024
1 parent 9656176 commit 5f48935
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 9 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
- **Issue 1:** Latest tag was used for docker. This is not ideal because if the user has latest locally, but there is a newer version on the container registry, then Docker will not pull it.<br>
**Fix 1:**: No Fix. In our readme, we explicitly tell the user to remove the existing local files first. Therefore, we do not run into this issue. <br>

### Milestone 2 Feedback
### Milestone 3 Feedback
- N/A

### Peer Review Feedback
Expand All @@ -61,4 +61,4 @@
[Commit Link](https://github.com/UBC-MDS/DSCI522-2425-22-wine-chromatic-profile/commit/29e1e5b9427cc202c8119da2a91e5e656b47063e#diff-059ae229d14bfbf15abe1e3587fcff94884f9497fffa3b5bdf6c2ff3e94f44d4R113)

- **Issue 6:** The PDF link in Other Formats under the html report is not working. <br>
**Fix 6:**: Not Fixed. Not within scope of this project <br>
**Fix 6:**: Not Fixed. Not within scope of this project <br>
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ where you launched the container, and then type `docker compose rm`
```
### Running the test suite
Use the same docker compose up command as described in the Running the analysis section above to launch Jupyter lab. Tests are run using the pytest command in the root of the project. More details about the test suite can be found in the tests directory.
Use the same docker compose up command as described in the Running the analysis section above to launch Jupyter lab. Tests are run using the pytest command in the `tests/` directory. More details about the test suite can be found in `tests/`.
# License
This project was created with the [`MIT License`](LICENSE.md)
Expand Down
16 changes: 10 additions & 6 deletions tests/README → tests/README.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
Use the bash command below to change directory from root to `tests/`
`cd tests`

Run each test one by one in the `tests/` directory:
```
pytest test_validate_column_names.py
pytest test_split_data.py
pytest -v test_random_search.py \
--train_data=../data/proc/wine_train.csv \
--test_data=../data/proc/wine_test.csv \
--pipeline_path=../results/models/wine_pipeline.pickle
pytest test_validate_column_names.py

pytest test_split_data.py

pytest test_evaluation.py
```

Test all at once with the command below:
Or run all tests at once in the `tests/` directory with the command below:
```
pytest -v \
--train_data=../data/proc/wine_train.csv \
--test_data=../data/proc/wine_test.csv \
--pipeline_path=../results/models/wine_pipeline.pickle
```
```

0 comments on commit 5f48935

Please sign in to comment.