Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarto dependency #42

Merged
merged 28 commits into from
Dec 7, 2024
Merged

Quarto dependency #42

merged 28 commits into from
Dec 7, 2024

Conversation

Farhan-Faisal
Copy link
Collaborator

@Farhan-Faisal Farhan-Faisal commented Dec 7, 2024

  • Updated environment file (quarto, jupyter, notebook, tabulate)
  • Merged in changes from script branches
  • Changes to eda.py => (removed figure titles)
  • Changes to model_evaluation.py => (used best_estimator for cross validation and changed table format)
  • Changed name of one script to clean_n_split.py
  • Added report.qmd, report.html, report.pdf
  • Created docs folder and copied over index.html
  • Made new docker file with fixed quarto permission issues

@Farhan-Faisal Farhan-Faisal added the enhancement New feature or request label Dec 7, 2024
@Farhan-Faisal Farhan-Faisal added this to the Milestone 3 milestone Dec 7, 2024
@Farhan-Faisal
Copy link
Collaborator Author

python download.py
--id 186
--save_to data/wine_ex.csv

python validation_before_split.py
--file_name wine_ex.csv
--data_path ../data/

python clean_n_split_data.py
--raw-data ../data/wine_ex.csv

python eda_n_correlation_check.py
--train-file ../data/wine_train.csv
--output-img ../results/figures
--output-table ../results/tables

python preprocessing.py
--pipe-to ../results/models

python model_evaluation_wine_predictor.py --train-data ../data/wine_train.csv
--test-data ../data/wine_test.csv
--pipeline-path ../results/models/wine_pipeline.pickle
--table-to ../results/tables
--plot-to ../results/figures

@Farhan-Faisal
Copy link
Collaborator Author

cd scripts
quarto render report.qmd --to pdf
quarto render report.qmd --to html

@Farhan-Faisal
Copy link
Collaborator Author

cp scripts/report.html ../docs
cd docs
mv report.html index.html

Copy link
Collaborator

@adrianl726 adrianl726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy

@adrianl726 adrianl726 merged commit 9c84451 into main Dec 7, 2024
3 checks passed
@adrianl726
Copy link
Collaborator

Author names should be ordered by last names tho

@Farhan-Faisal
Copy link
Collaborator Author

Didn't notice it should be by last names : (
Will fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants