small updates following async discussion #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acholyn
changed the title
tcouch
reviewed
Dec 9, 2024
mod_app/migrations/0026_alter_feedback_options_alter_projectnote_options.py
Show resolved
Hide resolved
| @@ -72,6 +72,8 @@ def get_absolute_url(self): | |||
| max_length=100, blank=True, null=True | |||
| ) # can use choices if preset | |||
|
|
|||
| bfi_identifier = models.CharField(max_length=7, blank=True, null=True) | |||
There was a problem hiding this comment.
How sure are you that this is only 7 characters? This wikidata entry for BFI National Archive work ID gives examples with 9 characters.
There was a problem hiding this comment.
It's what Aylin said 🤷 : my question followed by her answer in brackets
BFI identifier – are these always 5 digits or are they of variable length (eg 5-10 digits) and are they always numbers or do they sometimes have letters in as well? ( 6-7 numbers)
There was a problem hiding this comment.
Ok. Unless you're relying on the validation, personally I'd opt for allowing longer entries just in case.
tcouch
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #129 , #128 and #125 as well as updating verbose names to better distinguish
FeedbackandProjectNotemodels