splitting vwis into vis and written #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcouch
approved these changes
Jan 13, 2025
| extra = 1 | ||
| classes = [ | ||
| "grp-collapse", | ||
| "grp-open", | ||
| ] | ||
| verbose_name = "Visual & Written Influences" | ||
| verbose_name_plural = "Visual & Written Influences" | ||
| verbose_name = "Visual Influences" |
There was a problem hiding this comment.
Suggested change
| verbose_name = "Visual Influences" | |
| verbose_name = "Visual Influence" |
On the model you've defined verbose name as "Visual Influence" rather than "Visual Influences".
There was a problem hiding this comment.
yep, deliberate, since they're separate now I thought they might end up making new entries for each
There was a problem hiding this comment.
worst case I'm wrong and we change it back
| "grp-collapse", | ||
| "grp-open", | ||
| ] | ||
| verbose_name = "Written Influences" |
There was a problem hiding this comment.
Suggested change
| verbose_name = "Written Influences" | |
| verbose_name = "Written Influence" |
As above. Unless this is deliberate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual & Written Influences should be 2 separate models