Charvi/build devel amil ubuntu16.04 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by default the irods latest version was getting installed that is not supported by python2.7 version so specifying the version that is used in bisque production code base as well. Signed-off-by: charvi-077 <[email protected]>
The build command defined in the script was by default ignoring the build due to path error so correcting the syntax so that both build and start commands executes in the script. Signed-off-by: charvi-077 <[email protected]>
Update the docker file to include build from scratch dependencies and remove the commands not required. Also add biodev.ece.ucsb.edu as trusted source Signed-off-by: charvi-077 <[email protected]>
Also remove the commented code and add ca certificates dependencies Signed-off-by: charvi-077 <[email protected]>
Signed-off-by: charvi-077 <[email protected]>
For Module generator to run locally, intead of argo thats used in production we need to install the docker and spin containers for module generator Signed-off-by: charvi-077 <[email protected]>
Updated readme file, that includes the instructions to build image from the Dockerfile locally.
amilworks
requested changes
Jan 8, 2025
README.md
Outdated
|
|
||
| Clone the repository | ||
| ``` | ||
| git clone [email protected]:charvi-077/bisqueUCSB.git |
There was a problem hiding this comment.
This still refers to your your repository. This will be merged to master so you can just
git clone https://github.com/UCSB-VRL/bisqueUCSB.git
There was a problem hiding this comment.
Ohh yes, I will correct that. And yes for further changes in Readme I will create the separate ticket.
Correct the github repo link
amilworks
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below commits Includes :
To build the BisQue docker image locally from Dockerfile.