Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix empty predictions #147

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Bugfix empty predictions #147

merged 4 commits into from
Dec 4, 2024

Conversation

rubenpeters91
Copy link
Contributor

@rubenpeters91 rubenpeters91 commented Dec 3, 2024 •
edited
Loading

Changed

  • Dashboard now displays a warning when a patient is currently being called, instead of preventing the user from going to the next patient
  • Dashboard will give an informative error when a prediction is no longer available, instead of crashing. Furthermore the user can still navigate to the next patient when this occurs
  • Patient selection buttons now moved to a separate function

Closes: #144
Closes: #146

See: https://rsc.ds.umcutrecht.nl/connect/#/apps/a4f403a9-8d43-4757-8caf-c78fb0669dfc/

@rubenpeters91 rubenpeters91 added the bug Something isn't working label Dec 3, 2024
@rubenpeters91 rubenpeters91 self-assigned this Dec 3, 2024
WoltersEric
WoltersEric requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@WoltersEric WoltersEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes requested

WoltersEric
WoltersEric approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@WoltersEric WoltersEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean! LGTM!

@rubenpeters91 rubenpeters91 merged commit 2ba5e2b into main Dec 4, 2024
3 checks passed
@rubenpeters91 rubenpeters91 deleted the bugfix_empty_predictions branch December 11, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoltersEric WoltersEric WoltersEric approved these changes

@LauraVeerhoek LauraVeerhoek Awaiting requested review from LauraVeerhoek

Assignees

@rubenpeters91 rubenpeters91

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix outdated predictions when going through patient list Verify multi user option calling dashboard
2 participants
@rubenpeters91 @WoltersEric