Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty appointments bug fix #153

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Conversation

WoltersEric
Copy link
Contributor

closes #151

deploy.sh Show resolved Hide resolved
src/noshow/api/app.py Outdated Show resolved Hide resolved
@WoltersEric
Copy link
Contributor Author

WoltersEric commented Jan 6, 2025

I added your suggestions and an additional unit test. The latest version is now running on acceptance

src/noshow/api/app_helpers.py Outdated Show resolved Hide resolved
src/noshow/api/app_helpers.py Outdated Show resolved Hide resolved
src/noshow/api/app_helpers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rubenpeters91 rubenpeters91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think you need to change the monkeypatch for CLINIC_CONFIG, since it's also imported in app_helpers not only in app. That should fix the unit test

@rubenpeters91 rubenpeters91 merged commit 8175877 into main Jan 8, 2025
3 checks passed
@rubenpeters91 rubenpeters91 deleted the empty_appointments_bug_fix branch January 8, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check for empty data set in API, instead of cryptic error
2 participants