Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some columns required #192

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Make some columns required #192

merged 2 commits into from
Nov 22, 2024

Conversation

Pl217
Copy link
Contributor

@Pl217 Pl217 commented Nov 20, 2024

  • Admin command delete-broken-attachment developed for HPC-9832 has deleted attachments which had their planId column equal to NULL before, so we can make this column required now, as there is no data anymore which made it accidentally optional
  • In organization table, there are no records where abbreviation is NULL, so we can make it required now. In the old dumps, the organization with ID 1585, named "Kraft Foods Foundation", didn't specify abbreviation and there may have been others too, but all records have non-null abbreviation now

@Pl217 Pl217 added the ready for review All comments have been addressed, and the Pull Request is ready for review label Nov 20, 2024
@Pl217 Pl217 requested a review from a team as a code owner November 20, 2024 12:17
@enxtur enxtur assigned Pl217 and unassigned enxtur Nov 22, 2024
@enxtur enxtur added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Nov 22, 2024
@Pl217 Pl217 merged commit e205c63 into develop Nov 22, 2024
2 checks passed
@Pl217 Pl217 deleted the make-required branch November 22, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants