HPC-9944: Add v4 models to Role and WorkflowRole tables
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delgee
added
the
ready for review
manelcecs
requested changes
Jan 20, 2025
| export type WorkflowRoleId = Brand< | ||
| number, | ||
| { readonly s: unique symbol }, | ||
| 'workflowRole.id' | ||
| >; | ||
|
|
||
| export const WORKFLOW_ROLE_ID = brandedType<number, WorkflowRoleId>(t.number); | ||
|
|
||
| // export const PERMITTED_ACTION_IDS = t.union([ |
Pl217
requested changes
Jan 21, 2025
There was a problem hiding this comment.
The reason why v4 models don't have these tables is that they are considered legacy and should not be used in any new code. Since you need to write temporary admin command, which must fix corrupt legacy data, I think you can use legacy models for that purpose.
In related hpc_service PR, if you can write all code using v4 models and only use legacy models for legacy tables, that would be best. But, if combining models isn't possible in some place, it's fine to use legacy models there too, since it is a temporary thing, fixing legacy stuff.
Pl217
added
needs major changes
|
No longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.