-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPC-8663: add software info query #205
Conversation
I think it will be interesting to start adding test for GraphQL resolvers (now the project is on an early stage). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure CI checks are passing and then assign the PR to person who you want review from.
Regarding the tests, I agree, we should add them sooner rather than later. Since we don't have test coverage here or in common library between our APIs (hpc-api-core), we have tickets to add test coverage and setup testing in both repos. Look at HPC-8232 and HPC-8233.
There is also an idea to run the tests in transactions (HPC-7811) rather than deleting entire tables all the time. With all of this in mind, a work has started long time ago at UN-OCHA/hpc-api-core#26 and parts of it could potentially be used, but I suggest starting from scratch.
Added GraphQL resolver to query software info
67386f0
to
9678d81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks have passed and this pull request is ready for manual review
As described in HPC-8663 we needed a way to know wich version was deployed.
I've added a GraphQL resolver to query software info following this structure query
query { softwareInfo { title status version } }