Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC-8663: add software info query #205

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

manelcecs
Copy link
Contributor

@manelcecs manelcecs commented Sep 7, 2023

As described in HPC-8663 we needed a way to know wich version was deployed.
I've added a GraphQL resolver to query software info following this structure query
query { softwareInfo { title status version } }

@manelcecs manelcecs requested a review from a team as a code owner September 7, 2023 09:39
@manelcecs
Copy link
Contributor Author

I think it will be interesting to start adding test for GraphQL resolvers (now the project is on an early stage).
I can add the environment config (I thought of using ts-jest) but I don't know if it's suitable to add this in this PR or create a task where solve this situation.

Copy link
Contributor

@Pl217 Pl217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure CI checks are passing and then assign the PR to person who you want review from.

Regarding the tests, I agree, we should add them sooner rather than later. Since we don't have test coverage here or in common library between our APIs (hpc-api-core), we have tickets to add test coverage and setup testing in both repos. Look at HPC-8232 and HPC-8233.

There is also an idea to run the tests in transactions (HPC-7811) rather than deleting entire tables all the time. With all of this in mind, a work has started long time ago at UN-OCHA/hpc-api-core#26 and parts of it could potentially be used, but I suggest starting from scratch.

src/domain-services/software-info/software-info-service.ts Outdated Show resolved Hide resolved
@Pl217 Pl217 added the needs minor changes There are review or issue comments to address label Sep 8, 2023
Added GraphQL resolver to query software info
@manelcecs manelcecs force-pushed the HPC-8663-create-software-version-query branch from 67386f0 to 9678d81 Compare September 11, 2023 07:15
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs assigned Pl217 and unassigned manelcecs Sep 11, 2023
@manelcecs manelcecs added ready for review All comments have been addressed, and the Pull Request is ready for review and removed needs minor changes There are review or issue comments to address labels Sep 11, 2023
@Pl217 Pl217 merged commit 27e41fe into develop Sep 11, 2023
@Pl217 Pl217 deleted the HPC-8663-create-software-version-query branch September 11, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants