-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cone detection test #144
Open
AdrianRosioru
wants to merge
14
commits into
nightly
Choose a base branch
from
cone_detection_test
base: nightly
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cone detection test #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanish29
reviewed
Nov 29, 2024
Tanish29
reviewed
Nov 29, 2024
Tanish29
reviewed
Nov 29, 2024
Tanish29
reviewed
Nov 29, 2024
Tanish29
reviewed
Nov 29, 2024
Made changes as asked, ready to merge @Tanish29 |
thanks for the changes, there are still some files that need to be seen by another person (ideally Zane) since this is a big PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes made from last pull request to include new cone_detection thats implemented in C++
Cone Delete Implementation:
-Deletes cone if it has not been detected for long enough
-has some values that can be optimized based on if they are being used on jetson
Zed_launch launch file, simple launch file that has a description of what parameters it can take in:
only one parameter