Feat/Gokart #4
Merged
Feat/Gokart #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge latest main for definitions
Jack17432
requested changes
Apr 25, 2024
removed yml tags and fixed spelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CAN messages for the gokart.
Unresolved issues:
Written in the can.proto file are the bit lengths needed on the CAN frame for each value. These types are not supported by protobuf. The values are needed to be re-declared as int32/uint32, and within a ROS node or on the MoTec either needs values to be shift encoded into a single/two 32 bit integers or masking on each value values should be specified.