M024 AMS, IMD meas and other CAN message definced - Andy #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack17432
requested changes
Jun 8, 2024
| bool AMS_AUX_GPIO7 = 15; /* AMS's AUX GPIO 1 state, reserved for future purpose. */ | ||
|
|
||
| /* Below is about AMS firmware version*/ | ||
| int8 AMS_firmware_version = 17; /* Current AMS Firmware's version or equivalent info */ |
There was a problem hiding this comment.
If we wanna do this I recomend the first 4 char of a git commit and so please change this to a char[4] or other such data. This means that it auto sets the value depending on what git hash it is and so we can search through the commit history rather then each individual commit
Comment on lines
+49
to
+56
| message AMSError { | ||
| bool precharge_completed = 8; /* Only send this message with value of 1 at bit 7 once when precharge completed, so rising edge only. */ | ||
| } | ||
|
|
||
| /* Current ID: 0x106 */ | ||
| message AccNotReady{ | ||
| bool acc_not_ready = 8; /* Send this message when the ACC is not ready to enter TS Active mode. */ | ||
| } |
There was a problem hiding this comment.
Please merge this takes up to much space on the can line for what it dose
| bool AIR_NEG = 8; /* AIR Negative Relay State. 1 is closed, 0 is open */ | ||
| /* Current ID: 0x105 */ | ||
| message AMSError { | ||
| bool precharge_completed = 8; /* Only send this message with value of 1 at bit 7 once when precharge completed, so rising edge only. */ | ||
| } |
There was a problem hiding this comment.
O lol I thought this wasnt done yet my bad
Jack17432
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new AMS CAN message and old existing one included
IMD Measure output
AMS can read the frequency of the IMD_STM_MEAS pin to get more information about IMD state.
AMS AUX GPIO state
Each bit of byte 1 ID 0x101, reflects the GPIO state of the STM's AUX GPIO pin. these are reserved for future debug purpose.
AMS Firmware version
Its set as uint8, but feel free to use more byte if needed to represent AMS firmware version.
And there are some other old original stuff that are simply included to the protobuf, so it all kept in one place.
0x105
0x106