-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CWMVUE-634 Implements Access To Water Endpoint #1030
base: develop
Are you sure you want to change the base?
Conversation
0670b66
to
1d4ecf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"type" is a bit ambiguous, especially that is is describing the type of parameter (but not to be confused with parameter type inst/ave/const/etc). otherwise the structure looks good. I'd probably prefer parameter even if it doesn't exactly match the parameter in the time series identifier.
… include TimeSeriesIdentifierDescriptor
…resent mapping of location id to mapping of ts-type to ts-id.
41be4ec
to
4950f40
Compare
I don't hate it, but it's not giving me any warm and fuzzies for the future either. @jeffsuperglide, @adamscarberry can you grant @rma-bryson and @adamkorynta at least read access to the access to water repositories to see how you're using the various A2W tables. I don't recall the usage being super high. But since this particular interface and objects will be new to everyone it's a good time to at least consider changes to how the data is presented and I'm not involved enough on the A2W side to say if the proposed design will be sensible. It may just be that these new endpoints are only used for the district level control of things and it may not matter, but better to get a conversation started sooner rather than later. @rma-bryson I would suggest also considering the following scenario to provide a little more insight:
The current example and test has one, which isn't a good sample size for something that could be rather foundational to our various operations. |
@MikeNeilson Invites sent to @rma-bryson and @adamkorynta to join a2w-readonly team. You will find the majority of the sql here: https://github.com/USACE/a2w-api/blob/60558999c32d3ea4c0f477812cb5dc53e77e267f/api/models/locations.go#L83-L358 or here: https://github.com/USACE/a2w-api/blob/develop/api/models/timeseries.go @jeffsuperglide is the POC for the a2w-api |
…sts and further updates are needed here, but pausing work for now.
No description provided.