Threshold Graph Bugfix #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the as.factor function assigning levels to integers as characters in nonnumerically sorted ordered. Solution was to remove character casting.
|
Hey @KristinaMiljkovic, thanks for the PR! But it seems that the tests are not passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue was first identified with incorrect node labeling for graphs in the threshold function. The graphs were being assigned ID numbers based on the order they appeared in the output, not based on their internal ID number.
Solution
Upon debugging the threshold function we were able to determine it does work as intended. Solution to threshold graphing problem was determined to be a result of the as.factor function assigning levels to integers as characters in non numerically sorted ordered. Solution was to remove character casting in the misc.r script.