Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update axios formio response interceptor #389

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Feature/update axios formio response interceptor #389

merged 1 commit into from
Feb 28, 2024

Conversation

courtneymyers
Copy link
Collaborator

Related Issues:

  • CSBAPP-309

Main Changes:

  • Remove retry logic from axios formio response interceptor, as react-query internally has retry logic built-in
  • Fix setting of URL to be logged in error log

Steps To Test:

  1. Run the app locally, and change a Formio URL so the request fails.
  2. Ensure the error messages are logged.

@courtneymyers
Remove retry logic from axios formio response interceptor, as react-q…
d3346ff 
…uery internally has retry logic built-in, and fix setting of URL to be logged in error log
@courtneymyers courtneymyers merged commit fa5ff82 into develop Feb 28, 2024
1 check passed
@courtneymyers courtneymyers deleted the feature/update-axios-formio-response-interceptor branch February 28, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@courtneymyers