Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fetch nces from s3 #394

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

courtneymyers
Copy link
Collaborator

Related Issues:

  • CSBAPP-311

Main Changes:

Switch from serving the NCES.json file directly within the app to fetching it from the public S3 bucket – will allow for updating of the NCES data at any point in the future without having to go through a new scan/release.

Steps To Test:

  1. Create (or edit) a 2022 or 2023 FRF submission.
  2. Ensure the NCES data is fetched properly, and the Formio form still functions as expected (pay particular attention to any new latency due to the data now being fetched from the server).

@courtneymyers courtneymyers merged commit f9f7389 into develop Feb 28, 2024
1 of 2 checks passed
@courtneymyers courtneymyers deleted the feature/fetch-nces-from-s3 branch February 28, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant