Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update bap 2023 prf data queries #403

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

courtneymyers
Copy link
Collaborator

Related Issues:

  • CSBAPP-275

Main Changes:

  • Update BAP query for 2023 PRF data to get the bus contact org info in the 2023 FRF bus contacts queries themselves (via Contact__r.Account fields), which allows us to remove an additional (and no longer needed) query for the 2023 FRF bus contacts organizations. Functionally, should be the same result as before, just less queries and resulting data to parse and merge back together.
  • In making this update, I also realized I was accidentally previously setting the bus contact org's county field from the org's "BillingCountry" field, so I've updated it to be set properly from the org's "County__c" field.

Steps To Test:

  1. Ask the BAP to change an existing 2023 FRF submission's status to "Accepted"
  2. Create a new 2023 PRF submission.
  3. Ensure the injected data for organizations is correct (excluding "Private Fleet" orgs, which we still need guidance from the BAP on if we're able to get that data)

…o in the frf2023BusRecordsContactsQueries, and remove the no longer needed frf2023BusRecordsContactsOrgsQueries
@courtneymyers courtneymyers merged commit 5dc5cd0 into develop Mar 28, 2024
1 check passed
@courtneymyers courtneymyers deleted the feature/update-bap-2023-prf-data-queries branch March 28, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant