Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/implement deduplication web service #407

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

courtneymyers
Copy link
Collaborator

@courtneymyers courtneymyers commented Apr 3, 2024

Related Issues:

  • CSBAPP-332

Main Changes:

Initial implementation of the wrapper app to support BAP de-duplication efforts. From the wrapper side, it's really just a proxy for the BAP record matcher web service. This is a quick initial MVP to allow Formio form development to begin, but we'll want to apply some additional checks in the wrapper app's web service before making the request against the BAP.

Steps To Test:

  1. Post some 'duplicate' contact or org data to the web service endpoint (be sure to include the x-api-key header) and ensure you're getting a response
  2. Ensure you get an appropriate error message if you don't include the proper api key header

TODO:

  • Update web service to perform checks (TBD) before issuing request against the BAP (e.g., checking shape of post body, ensuring certain fields exist, ensuring post body isn't too large, etc.)

@courtneymyers courtneymyers merged commit 77e0832 into develop Apr 4, 2024
2 checks passed
@courtneymyers courtneymyers deleted the feature/implement-deduplication-web-service branch April 4, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant