Completed Bootcamp #128
Completed Bootcamp #128
Conversation
| result, box = bounding_box.BoundingBox.create(boxes_cpu[i]) | ||
| if result: | ||
| bounding_boxes.append(box) |
There was a problem hiding this comment.
its common practice to disregard the entire inference if there is any result
There was a problem hiding this comment.
Could you explain more? Why should the inference be disregarded if there is an result? What's the point of having a list of boxes then? Thank you!
| else: | ||
| command = commands.Command.create_land_command() |
There was a problem hiding this comment.
the intended solution is to add another is_same check here with the landing pad location. in fact this one matters a lot more than the previous check as you need to be physically landing on a landing pad
| @@ -69,6 +79,17 @@ def run( | |||
| # ============ | |||
|
|
|||
| # Do something based on the report and the state of this class... | |||
| if report.status.name == "HALTED": | |||
There was a problem hiding this comment.
I wouldnt usually do equality by name here, you can directly associate with class type. but you don't have to make the change here since it would still work
| return ( | ||
| abs(position.location_x - self.waypoint.location_x) ** 2 | ||
| + abs(position.location_y - self.waypoint.location_y) ** 2 | ||
| < self.acceptance_radius**2 | ||
| ) |
There was a problem hiding this comment.
good job not using sqrt to reduce computation
| @@ -38,11 +38,36 @@ def __init__(self, waypoint: location.Location, acceptance_radius: float) -> Non | |||
| # ============ | |||
|
|
|||
| # Add your own | |||
| self.closest_landing_pad = location.Location(0, 0) | |||
There was a problem hiding this comment.
initialization with none is probably better convention, the value of location(0,0) will never be used
| command = commands.Command.create_land_command() | ||
| elif report.status.name == "MOVING": | ||
| # At waypoint OR waypoint has been reached and at landing pad. | ||
| if self.is_same(self.waypoint, report.position) or ( |
There was a problem hiding this comment.
this wouldnt work as the drone may never leave the waypoint.
the goal is for the drone to arrive at the waypoint, snap a picture to find landing pads, and move to an apprioate landing pad to land on.
I think elif moving: pass is fine here
No description provided.