Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NP-862 replicator support cura cloud #352

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

jellespijker
Copy link
Member

Curator has the following assumptions when creating the matcher for a material.

If in the machine block of an fdm_material there is ANY hotend defined then the other hotends for that material are incompatible. See UltiMaker PLA forn the S-lines they don't define CC and DD cores therefore and Cura marks them as incompatible.

If there are NO hotend defined in any hotend for that machine is compatible.

And a dev can set the the hardware compatibility explicit to yes/no

This seemed to work for everything, but apparently Cura still does some other Voodoo Magic.

Adding support in the resources itself is easier than changing the business logic in Curator for this:

Which has a change to introduce regressions in our existing printer support. This should not change the behaviour of Cura

Contribute to NP-862

FYI @Frederic98, @pkuiper-ultimaker and @alanbjorklund

Curator has the following assumptions when creating the matcher for  a material.

If in the machine block of an fdm_material there is **ANY** hotend defined then the other hotends for that material are incompatible. 
See UltiMaker PLA forn the S-lines they don't define CC and DD cores therefore and Cura marks them as incompatible.

If there are **NO** hotend defined in any hotend for that machine is compatible.

And a dev can set the the hardware compatibility explicit to yes/no

This seemed to work for everything, but apparently Cura still does some other Voodoo Magic.

Adding support in the resources itself is easier than changing the business logic in Curator for this:
- https://github.com/Ultimaker/Curator/blob/c3c0c5a62b4579dd1d69c63d24124a1fa944df5c/include/curator/settings/data/material.h#L250
- https://github.com/Ultimaker/Curator/blob/c3c0c5a62b4579dd1d69c63d24124a1fa944df5c/include/curator/configuration/matching_rules.h#L190


Which has a change to introduce regressions in our existing printer support. This should not change the behaviour of Cura

Contribute to NP-862
@jellespijker
Copy link
Member Author

@alanbjorklund and/or @pkuiper-ultimaker I wanted to confirm; should PLA be compatible with Smart Extruder+ Experimental at all in Cura?

@pkuiper-ultimaker
Copy link
Contributor

@alanbjorklund and/or @pkuiper-ultimaker I wanted to confirm; should PLA be compatible with Smart Extruder+ Experimental at all in Cura?

In CloudPrint I cannot find the "Smart Extruder+ Experimental". It only appears to be available in the Cura profiles.
Also when I check Cloudrint the PLA is only compatible with the "Smart Extruder+" and Tough PLA is only compatible with the "Tough Smart Extruder+"

image

However, the Cura profiles show that PLA and Tough PLA are compatible with the following three extruders:

image

So I'm a bit confused. @alanbjorklund what are the valid configurations?

@alanbjorklund
Copy link
Contributor

The intended Smart Extruder configurations are:

1- PLA (Smart Extruder+)
2- TPLA (Smart Extruder+ Tough)
3- Any material (Smart Extruder+ Experimental)

The third option is available in CloudPrint, but only when a printer is connected with this extruder attached. We decided to remove this restriction when slicing in Cura because it seems needlessly complicated.

I just checked 5.10 stable and the three configurations listed above seem to be behaving as expected. (blocking PLA with the Smart Extruder+ Tough).

Screenshot 2025-03-28 at 9 10 16 AM

@jellespijker
Copy link
Member Author

jellespijker commented Apr 1, 2025

@wawanbreton it seems to behave in Cura, please merge these current changes therefore.

@alanbjorklund and @pkuiper-ultimaker can you guys update the material generator to always explicitly mention the hot-end you want to support, if there is atleast one one hot-end defined for a machine. For the reasons see above

@wawanbreton wawanbreton merged commit 66ea9dd into 5.10 Apr 2, 2025
8 checks passed
@wawanbreton wawanbreton deleted the NP-862_replicator_support_cura_cloud branch April 2, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants