Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make new event-type "STATELESS" for stateless incidents instead of "START" #346

Closed
hmpf opened this issue Feb 28, 2022 · 1 comment
Closed

Make new event-type "STATELESS" for stateless incidents instead of "START" #346

hmpf opened this issue Feb 28, 2022 · 1 comment
Assignees
@stveit
Labels
API v2 Ideas for API v2, backwards incompatible OK API Affects Argus' REST API data model Affects the data model and/or SQL schema enhancement New feature or request frontend Affects frontend

Comments

@hmpf
Copy link
Contributor

hmpf commented Feb 28, 2022 •
edited by lunkwill42
Loading

If an Incident is posted with an end_time value of None, log this as a STATELESS Event, else, make a START event (like before).

In partial fulfillment of #206.
@hmpf hmpf added frontend Affects frontend data model Affects the data model and/or SQL schema labels Feb 28, 2022
@hmpf hmpf changed the title Make new event-type "STATELESS" for stateless incidnts instead of "START" Make new event-type "STATELESS" for stateless incidents instead of "START" Feb 28, 2022
@hmpf hmpf added enhancement New feature or request API Affects Argus' REST API API v2 Ideas for API v2, backwards incompatible OK labels Feb 28, 2022
@hmpf
Copy link
Contributor Author

hmpf commented Feb 28, 2022

This will need a data migration that replaces the start event on existing stateless incidents with the new state-type, and back again.

@stveit stveit mentioned this issue Mar 1, 2022
Merged
@stveit stveit closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stveit stveit

Labels
API v2 Ideas for API v2, backwards incompatible OK API Affects Argus' REST API data model Affects the data model and/or SQL schema enhancement New feature or request frontend Affects frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hmpf @stveit