Add new Event type stateless #352
Conversation
| def update_event_type(apps, schema_editor): | ||
| # Change INCIDENT_START events for stateless incidents to STATELESS | ||
| Event = apps.get_model('argus_incident', 'Event') | ||
| for event in Event.objects.all(): | ||
| if event.type == "STA" and event.incident.end_time == None: | ||
| event.type="LES" | ||
| event.save() | ||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('argus_incident', '0004_alter_event_type'), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.RunPython(update_event_type), | ||
| ] |
There was a problem hiding this comment.
Move this into the previous file (the function and append the RunPython to the end of the operations list.
Also, add a reversal function (second arg to RunPython).
tests/incident/test_event.py
Outdated
| description=f"Incident #{source_incident_id} created for testing", | ||
| ) | ||
| event_stateless = incident.events.filter(type=Event.Type.STATELESS) | ||
| self.assertEqual(1, len(event_stateless)) |
There was a problem hiding this comment.
event_stateless is a queryset, so do event_stateless.count() instead of len(). This makes postgres do the count, not python.
|
Oh, and you're working from an outdated master-branch, so there might be merge-shenaningans. |
Instead of first event being INCIDIENT_START, now stateless events use the STATELESS event type. Stateful incididents still get an INCIDENT_START event
stveit
force-pushed
the
event_type_stateless
branch
from
009d823 to
d6c404a
Compare
|
Added reverse function for migration. |
| def remove_stateless_event_type(apps, schema_editor): | ||
| # undo changes made by add_stateless_event_type | ||
| Event = apps.get_model('argus_incident', 'Event') | ||
| for event in Event.objects.all(): | ||
| if event.type == "LES": | ||
| event.type = "STA" | ||
| event.save() |
I don't think there is, and I think it is three letters because that's the length of "END". The sole purpose of saving a string here instead of a key to a data table is for human convenience, and it isn't that much more expensive to have a much longer string, and not even demand the same length for each. |
Fix for #346
Adds new event type called
STATELESS. This is used instead ofINCIDENT_STARTfor the initial event when a stateless incident is created. Stateful incident will still start with aÌNCIDENT_STARTevent.Adds a small test that checks if a stateless event is created when a new stateless incidents is created.
Adds migration files for adding
STATELESStype and update old entries such thatINCIDENT_STARTevents that belong to stateless incidents get switched toSTATELESS.