Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow showing just count for specific incident filter #345

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Feb 28, 2022

Bu adding "count" as a GET query prameter, return a mini-response with just the count and filter:

{
  "count": 34567,
  "params": {
    "stateful": True,
  }
}

@hmpf
Copy link
Contributor Author

hmpf commented Feb 28, 2022

For, but not sufficient to close, #206

@hmpf hmpf requested a review from lunkwill42 February 28, 2022 09:29
@hmpf hmpf added API Affects Argus' REST API API v2 Ideas for API v2, backwards incompatible OK labels Feb 28, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@da49115). Click here to learn what that means.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #345   +/-   ##
=========================================
  Coverage          ?   72.10%           
=========================================
  Files             ?       68           
  Lines             ?     2592           
  Branches          ?        0           
=========================================
  Hits              ?     1869           
  Misses            ?      723           
  Partials          ?        0           
Impacted Files Coverage Δ
src/argus/incident/views.py 69.58% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da49115...b48e575. Read the comment docs.

@hmpf hmpf merged commit a917ff2 into Uninett:master Feb 28, 2022
@hmpf hmpf deleted the hidden-count branch February 28, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API v2 Ideas for API v2, backwards incompatible OK API Affects Argus' REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants