update addresses #445
Merged
update addresses #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianakocsis
commented
Feb 6, 2025
dianakocsis
commented
Feb 6, 2025
dianakocsis
commented
Feb 6, 2025
dianakocsis
commented
Feb 6, 2025
dianakocsis
commented
Feb 6, 2025
dianakocsis
commented
Feb 6, 2025
dianakocsis
commented
Feb 6, 2025
UnsupportedProtocol was also deployed for all the cases of NFT protocols not being available on some chains, even if v2 was supported! |
hensha256
reviewed
Feb 7, 2025
hensha256
reviewed
Feb 11, 2025
| @@ -1,4 +1,3 @@ | |||
| { | |||
| "UniversalRouter": "0x78e7F1502A9e4115dEbd6876E0AC4FaEBDB96880", | |||
There was a problem hiding this comment.
👀 how come you removed this?
This is URV2, it supports v4
There was a problem hiding this comment.
ohh i thought u said we should remove it #445 (comment)
or should i just change it to URV2?
There was a problem hiding this comment.
oh yeah youre right lol
Co-authored-by: Alice <[email protected]>
hensha256
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR v1 - doesn't support as many NFT protocols
UnsupportedProtocol - deployed if there is no support for v2 or for some nft protocols
UR v1.2 (v2 support or no v2 support) - added support for more NFT protocols
UR v2 - doesn't support NFT protocols, has v4 support