-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Added support for F13 to F24 keys #2075
Conversation
Packages/com.unity.inputsystem/InputSystem/Devices/Precompiled/FastKeyboard.cs
Outdated
Show resolved
Hide resolved
aacee0a
to
0db68be
Compare
0db68be
to
a0bec17
Compare
a0bec17
to
3d98e5d
Compare
e01e2a2
to
b081c2c
Compare
/// Don't use this. This is a dummy key that is only used internally to represent the IME selected state. | ||
/// Will be removed in the future. | ||
/// </summary> | ||
IMESelected, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add an [Obsolete(..., false)] do this one to generate a warning, to discourage usage
the package api validation tool accept it : https://unity-ci.cds.internal.unity3d.com/job/47020274
I only need to add an exception in our test APIVerificationTests.
Let me know your opinion, IMAO we should add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's going to need exception in APIVerificationTests if marked obsolete maybe leave it as IMO. However we should get a ticket filed on removing this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit on a test branch d09d546#diff-9de7ba7ca03e154a8f9bb4204633a956e529e0a8cb309c70ab7be6f3c28bc4dd it seems pretty trivial and would prevent people from using it.
let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, yeah that looks clean, let's get that in then. (I will assume this happens without additional review/approval since you provided a reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to resolve this thread when you have read it
@bmalrat Looks like there is a bunch of conflicts on the branch in assembly files and generated precompiled layouts that need to be addressed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple conflicts in precompiled layouts and assembly info files needs to be addressed
…f14-f15 # Conflicts: # Assets/Samples/InGameHints/InGameHintsActions.cs # Assets/Samples/SimpleDemo/SimpleControls.cs # Assets/Tests/InputSystem/InputActionCodeGeneratorActions.cs # Packages/com.unity.inputsystem/InputSystem/AssemblyInfo.cs # Packages/com.unity.inputsystem/InputSystem/Devices/Precompiled/FastKeyboard.cs # Packages/com.unity.inputsystem/InputSystem/Devices/Precompiled/FastMouse.cs # Packages/com.unity.inputsystem/InputSystem/Devices/Precompiled/FastTouchscreen.cs # Packages/com.unity.inputsystem/Tests/TestFixture/AssemblyInfo.cs # Packages/com.unity.inputsystem/package.json
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemed fine to me, able to use the additional function keys in scripts just fine (Both with Input manager and Input System versions) as well as in the shortcut manager
Seems conflicts are resolved now so will approve this PR. The suggested obsoletion mentioned in one of the threads makes sense to add @bmalrat but I will approve this upfront assuming that part is included in the merge. |
Description
https://jira.unity3d.com/browse/UUM-44328
Key.IMESelected
to obsolete which was not a real key. Please use the ButtonControlimeSelected
.Testing status & QA
tested on mac/windows/linux
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: