Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6000.1] [UUM-78961] Fixed initialization of a class which has last fields in a table with 65535 field entries and the next class having no fields #2090

Merged
merged 2 commits into from
Nov 8, 2024
Merged

[6000.1] [UUM-78961] Fixed initialization of a class which has last fields in a table with 65535 field entries and the next class having no fields #2090

merged 2 commits into from
Nov 8, 2024

Conversation

alexey-zakharov
Copy link

@alexey-zakharov alexey-zakharov commented Nov 7, 2024 •
edited
Loading

Backport of #2081

  • Should this pull request have release notes?
    • Yes
    • No
  • Do these changes need to be back ported?
    • Yes
    • No
  • Do these changes need to be upstreamed to mono/mono or dotnet/runtime repositories?
    • Yes
    • No

Reviewers: please consider these questions as well! ❤️

Release notes

Fixed UUM-78961 @alexeyzakharov:
Mono: Fixed crash when loading a class which contains fields at the end of the metadata table with a table size 65535.

@alexey-zakharov
Fixed initialization of a class which has last fields in a table with…
4bc0dc3 
… 65535 field entries and the next class having no fields

(cherry picked from commit 0888d04)
(cherry picked from commit bdee9a3)
@alexey-zakharov
Add non-null entry check for the MethodList too, so that last entry o…
72fdc88 
…f the table with 65635 methods and 0 in MethodList index in the last type doesnt crash

(cherry picked from commit 6e37765)
@alexey-zakharov alexey-zakharov marked this pull request as ready for review November 7, 2024 17:25
@alexey-zakharov alexey-zakharov self-assigned this Nov 7, 2024
@alexey-zakharov alexey-zakharov changed the title 6000.1/bugfixes/fix fieldlist 65535 fields [6000.1] [UUM-78961] Fixed initialization of a class which has last fields in a table with 65535 field entries and the next class having no fields Nov 7, 2024
@alexey-zakharov alexey-zakharov merged commit 0766c5b into unity-6000.1-mbe Nov 8, 2024
11 of 12 checks passed
@alexey-zakharov alexey-zakharov deleted the 6000.1/bugfixes/fix-fieldlist-65535-fields branch November 8, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scott-ferguson-unity scott-ferguson-unity scott-ferguson-unity approved these changes

Assignees

@alexey-zakharov alexey-zakharov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexey-zakharov @scott-ferguson-unity