Feat: Add UsdTransform2d export support #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR adds support for UsdPreviewSurface UsdTransform2d export – allowing to export texture offset/tiling to USD and USDZ.
Spec here: https://graphics.pixar.com/usd/release/spec_usdpreviewsurface.html#transform2d
This also works in QuickLook, but it seems that the order of operations is wrongly implemented there – will do a bug report. It's still useful for scale though.
glTF:
usdview:
Overall Product Risks
Complexity:
Low
Halo Effect:
Low
Additional information
Note to reviewers:
Currently not implemented for import. Also haven't tested what happens when exporting animated UV offsets, which I think would be outside of the scope of this PR (other samplers also don't fully support animation).
Open questions: