Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update snapshotsのコミットが落ちるのを直す #2389

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

タイトル通りです。

関連 Issue

スクリーンショット・動画など

(なし)

その他

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner December 3, 2024 22:02
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team December 3, 2024 22:02
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Dec 3, 2024

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:c9863ac

@sevenc-nanashi sevenc-nanashi changed the title Fix: コミットが落ちるのを直す Fix: update snapshotsのコミットが落ちるのを直す Dec 3, 2024
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あっれ!! withの中ってenv使えないんでしたっけ。。すみません。。

runner.tempだったらcontextなのでいけるかも。。。
https://docs.github.com/ja/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#example-usage-of-the-runner-context

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こことかwithの中でenv.使えてそうなんですけどね。。。。。。。。
Github Workflowなんもわからん。。。。。。。。
https://github.com/VOICEVOX/voicevox/pull/2389/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R95-R97

追記)
RUNNER_TEMPはenv.でアクセスできない環境変数らしい!!!!!!!!なんじゃそりゃ!!!!!!
https://docs.github.com/ja/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables

[update snapshots]
@sevenc-nanashi
Copy link
Member Author

runner.tempでちょうど良さそう?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

workflow、トラップが多いですねぇ。。😇
ローカルで試せないのがなぁ。。

@Hiroshiba Hiroshiba merged commit b1ae10d into VOICEVOX:main Dec 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants