Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extractVvppのテストを書く #2498

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Jan 20, 2025

内容

extractVvppのテストを書きました。
正常系のテストと異常系のテストをとりあえず書いています。

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 20, 2025 17:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • tests/unit/backend/electron/vvpps/invalid_manifest.vvpp/engine_manifest.json: Language not supported
  • tests/unit/backend/electron/vvpps/no_engine_id.vvpp/engine_manifest.json: Language not supported
  • tests/unit/backend/electron/vvpps/perfect.vvpp/engine_manifest.json: Language not supported
Comments suppressed due to low confidence (1)

tests/unit/backend/electron/vvppFile.node.spec.ts:41

  • The error message for the 'no_engine_id.vvpp' test case is not defined. Please provide a specific error message for this scenario.
"no_engine_id.vvpp", undefined
@Hiroshiba
Copy link
Member Author

@sevenc-nanashi よかったらレビューお願いできると!!

@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:2eff0cf

Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう。

@Hiroshiba
Copy link
Member Author

レビューありがとうございます!!!

@Hiroshiba Hiroshiba enabled auto-merge January 21, 2025 06:50
@Hiroshiba Hiroshiba added this pull request to the merge queue Jan 21, 2025
Merged via the queue into VOICEVOX:main with commit bd4cfbd Jan 21, 2025
11 checks passed
@Hiroshiba Hiroshiba deleted the hiho-20250121-020608 branch January 21, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants