-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Surround fixup #6860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Surround fixup #6860
Conversation
@@ -240,6 +240,8 @@ class Configuration implements IConfiguration { | |||
|
|||
surround = true; | |||
|
|||
disableDefaultPluginMappings = false; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about this switch: I want to do one switch for all cases (right now there is only surround. there might be coerce cr or exchange cx).
Not one per possible plugin; that would bloat the code and config.
the only real use case I see, is the few users with custom keyboard layouts. For that, mappings like cr or cx will be wrong same as cs.
I'm looking for updates on this PR 👀 |
3c621db
to
2d2b5fa
Compare
Hi @J-Fields can we get this merged? |
Hi @J-Fields I changed the flag as you suggested. Build now fails because "prettier" on Readme.me. Can you fix that? Should be simple. The code itself builds and works. |
Any chance this could be merged? This would greatly help users of alternative keyboard layouts. |
Co-authored-by: Quaid Bartolomei <[email protected]>
Please, merge this |
Hello, I'd like this merged as well |
I created this PR, with a green CI, so it could be merged |
What this PR does / why we need it:
This deals with a few minor issues, that came up with surround rewrite.
Which issue(s) this PR fixes
fixes #6812
fixes #6743
fixes #6848
fixes #7003
Special notes for your reviewer:
I tested this, with the switch set, there is no map on cs and lagfree maps on c are possible.