Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update port_compiler tag #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slashmili
Copy link

@slashmili slashmili commented Feb 25, 2018

For some reason @blt has decided today to change the tags and add v in front of all tags. removing the tag causes the new builds in our production to fail 😞

I'll also make a release to hex

For some reason https://github.com/blt/port_compiler decided to change
the tags and add v infront of all tags. removing the tag causes the new
builds to fail
@slashmili
Copy link
Author

1.0.6 has been released to hex

@Vagabond could you please merge this PR to master?

@blt
Copy link

blt commented Feb 25, 2018

@slashmili FWIW I don't maintain that library any longer. @Tuncer has been doing tagging work as a part of blt/port_compiler#29 I think?

@ghost
Copy link

ghost commented Feb 25, 2018

1.6.0 was the outlier, all other tags were already of the form vX.Y.Z. While creating the proper v1.6.0, I removed 1.6.0. Sorry about that. I have restored the tag, since it might have been used in more configs.

To be clear, this was done since pc (including 1.6.0) is already on hex.pm, and those using the rebar3 plugin were expected to get it from hex.pm. Therefore, the removal of the improper tag (missing prefix and not an annotated tag) was deemed low risk. Again, sorry for the hiccup and thanks for the quick notification.

If anyone's wondering why you might want to prefix tags:

  • easy filtering
  • easy way to create maintenance branches (1.2 branch vs v1.2.3 release)
  • it's a common convention to use a scheme like the v prefix or something project specific like Erlang's OTP-1.2.3.4

@ghost
Copy link

ghost commented Feb 25, 2018

@slashmili, does this resolve the issue for you?

BTW, I recommend to fetch the plugin from hex.pm, since it will get cached locally and shared between projects.

@slashmili
Copy link
Author

@Tuncer thanks, I already fixed erlang-syslog and used the correct version and pushed to hex.

I'm not familiar with rebar so I'll leave it to @Vagabond to use hex instead of git.

BTW thanks for your explanation your. You reasoning sound solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants